Fix isort import-ordering drift in bump.py#3611
Open
brendancol wants to merge 2 commits into
Open
Conversation
Cat 4 (isort): collapse the vertical-hanging-indent xrspatial.utils import block to a two-line grid wrap under line_length=100. flake8 baseline was already 0; no behavior change. Also record the bump row in the style-sweep state CSV. Found by /sweep-style deep sweep (2026-07-02).
brendancol
commented
Jul 2, 2026
brendancol
left a comment
Contributor
Author
There was a problem hiding this comment.
PR Review: Fix isort import-ordering drift in bump.py
This is a lint-only change. The one code edit reflows the from xrspatial.utils import (...) block from a one-name-per-line layout to the two-line grid wrap that the configured isort (line_length=100) produces. The imported names are unchanged (ArrayTypeFunctionMapping, _validate_scalar, has_cuda_and_cupy, is_cupy_array, ngjit), so there is no runtime effect. The other diff hunk is the style-sweep state CSV row.
Blockers (must fix before merge)
None.
Suggestions (should fix, not blocking)
None.
Nits (optional improvements)
None. The reformat matches isort output exactly and both resulting lines (91 and 50 columns) stay under the 100-column limit, so flake8 is still clean.
What looks good
- No behavior change: same names, same order, only the wrapping differs.
- flake8 baseline was already 0 and stays 0; isort is clean after the change.
- The 18-test bump suite still passes with CUDA available, so the cupy and dask+cupy paths were exercised.
Checklist
- Algorithm matches reference/paper (unchanged; no algorithm touched)
- All implemented backends produce consistent results (import-only change; tests pass on all four)
- NaN handling is correct (unchanged)
- Edge cases are covered by tests (existing coverage unaffected)
- Dask chunk boundaries handled correctly (unchanged)
- No premature materialization or unnecessary copies (no logic change)
- Benchmark exists or is not needed (not needed for a lint fix)
- README feature matrix updated (not applicable)
- Docstrings present and accurate (unchanged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3609
What
Run isort on
xrspatial/bump.pyto fix a Cat 4 import-ordering finding. Thefrom xrspatial.utils import (...)block was laid out one name per line; the configured isort (line_length=100) wraps it as a two-line grid instead.Categories addressed
except, no mutable default args, no shadowed builtins.Test plan
flake8 xrspatial/bump.pycleanisort --check-only xrspatial/bump.pycleanxrspatial/tests/test_bump.pypasses (18 tests, CUDA available so cupy and dask+cupy paths ran)xrspatial.utilsnames resolveFound by the /sweep-style deep sweep (2026-07-02).