Updated Example and few adjustments on .hybridVertical style#29
Merged
Conversation
Should take into account the text size.
Use half-range for loop and #selector macro
* vertical-hybrid-improvements: Modernized code style. imageEdgeInsets and titleEdgeInsets calculation
4 points extra inset is not necessary, for titleEdgeInsets
Should take into account the text size.
Use half-range for loop and #selector macro
4 points extra inset is not necessary, for titleEdgeInsets
* swift-3: Migrated to Swift 3 & fixed example Pods resizing of image is only needed if it exceed the max size 12 from the top for image, 4 for title Modernized code style. imageEdgeInsets and titleEdgeInsets calculation Update README.md Update AppDelegate.swift Update ViewController.swift Update Tests.swift Update XMSegmentedControl.swift Add the ability to set the selectedSegment index programmatically Update README.md Update README.md Fixed test cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@xaviermerino I have mostly updated the Example project setup.
Also, a few adjustments on the Hybrid Vertical style. These probably won't fit everyone's need on what's the proper insets on the image / title.
Probably a more generic solution such as the one from @dbburgess in #23 to be able to adjust image and title insets is needed. Once #23 is resolved, I'll revise my changes again.