Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors event naming and access modifiers while updating test fixtures and dependencies. The key changes include renaming UI event and error state types, converting sealed classes to sealed interfaces, and modifying coroutine collection behavior in the composable functions.
Reviewed Changes
Copilot reviewed 26 out of 34 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| presentation/users/src/main/kotlin/com/random/users/users/screen/UsersScreen.kt | Refactored event types in UI state functions |
| presentation/users/src/main/kotlin/com/random/users/users/navigation/UsersRoute.kt | Changed sealed class to sealed interface for navigation routes |
| presentation/users/src/main/kotlin/com/random/users/users/mapper/UsersErrorsMapper.kt | Updated error mapping to align with renamed error state |
| presentation/users/src/main/kotlin/com/random/users/users/contract/UsersScreenContract.kt | Updated contracts to reflect new event and error state naming |
| presentation/users/src/main/kotlin/com/random/users/users/composable/UserSearchView.kt | Added flow-based search handling with LaunchedEffect and snapshotFlow |
| presentation/users/src/main/kotlin/com/random/users/users/composable/UserList.kt | Switched to collectLatest when loading additional users |
| domain/src/test/... | Updated test classes and helper objects with internal modifiers |
| data/src/test/... | Adjusted tests and mother objects' visibility modifiers |
| core/presentation/src/main/kotlin/com/random/user/presentation/navigation/BaseNavRoutes.kt | Converted sealed class to sealed interface for navigation |
| app/src/main/kotlin/com/random/user/navigation/RandomUsersNavHost.kt | Removed redundant theme import |
Files not reviewed (8)
- core/api/build.gradle.kts: Language not supported
- core/database/build.gradle.kts: Language not supported
- core/preferences/build.gradle.kts: Language not supported
- core/test/.gitignore: Language not supported
- core/test/build.gradle.kts: Language not supported
- core/test/proguard-rules.pro: Language not supported
- data/build.gradle.kts: Language not supported
- presentation/users/build.gradle.kts: Language not supported
presentation/users/src/main/kotlin/com/random/users/users/composable/UserSearchView.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleted core:test (need to see test fixtures)
Moved test di modules to feature