Skip to content

add option for keyart#248

Merged
rmrector merged 1 commit intoxbmc:masterfrom
rmrector:keyart
Feb 28, 2026
Merged

add option for keyart#248
rmrector merged 1 commit intoxbmc:masterfrom
rmrector:keyart

Conversation

@rmrector
Copy link
Contributor

posters without text.

@kodiai
Copy link

kodiai bot commented Feb 28, 2026

Kodiai Review Summary

What Changed

Adds an option to separate TMDb posters without titles (keyart) from regular posters. Reviewed: core logic, tests

Strengths

  • ✅ Consistent implementation pattern matching existing artwork types (landscape, fanart)
  • ✅ Proper fallback behavior when keyart is disabled - merges back into poster collection preserving all images

Observations

Impact

[MAJOR] python/lib/tmdbscraper/tmdb.py (232): Mutable default argument
Function _build_image_list uses mutable default languages=[] which can cause unexpected behavior when the default is mutated across calls.

Preference

[MINOR] python/lib/tmdbscraper/tmdb.py (229): Function renamed but serves dual purpose
Optional: The rename from _build_fanart_list to _build_list_without_titles is more generic but now serves both fanart and keyart. Consider documenting this dual purpose in a comment.

Suggestions

  • Future consideration: Add integration tests for the keyart configuration flow end-to-end

Verdict

🔴 Address before merging -- (1) blocking issue(s) found (CRITICAL/MAJOR)

Review Details
  • Files reviewed: 6
  • Lines changed: +38 -10
  • Profile: strict (auto, lines changed: 48)
  • Author: core (adapted tone)
  • Findings: 0 critical, 1 major, 0 medium, 1 minor (includes 2 from summary observations)
  • Review completed: 2026-02-28T17:17:54.488Z
  • Keyword parsing: No keywords detected

posters without text.
@rmrector rmrector merged commit 9c1f05f into xbmc:master Feb 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant