Skip to content

Add addon check#59

Open
razzeee wants to merge 3 commits intoxbmc:matrixfrom
razzeee:add-addon-check
Open

Add addon check#59
razzeee wants to merge 3 commits intoxbmc:matrixfrom
razzeee:add-addon-check

Conversation

@razzeee
Copy link
Copy Markdown
Member

@razzeee razzeee commented Oct 16, 2021

@pkscout please let me know if this is okay for you.

Then we'll need to add the environment variables

Copy link
Copy Markdown
Member

@pkscout pkscout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, although someone will have to step me through how to submit updates to the addon repo with this. The md file with the directions only sort of made sense to me.

@razzeee
Copy link
Copy Markdown
Member Author

razzeee commented Oct 16, 2021

That's a problem, can we talk about it and try to sort out, which infos your missing?

@pkscout
Copy link
Copy Markdown
Member

pkscout commented Oct 16, 2021

I'm absolutely fine merging this and then figuring it out. This looks like a much easier way to submit updates than what I've been doing. I've just never used tags except on the GitHub site, so I'm not sure what I would have to do with the git pushes to make sure everything is done right. I suspect if someone walked me through it next time there is an update to be done, I'd be fine after that. Shoot, if I can figure this out, I might start using it on some of my own add-ons to make the publishing easier.

@razzeee
Copy link
Copy Markdown
Member Author

razzeee commented Oct 16, 2021

We'll need to sort the variables, I've posted about it in slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants