Conversation
om26er
force-pushed
the
payload-codecs
branch
from
bcc6c84 to
c7216d7
Compare
Mahad-10
force-pushed
the
payload-codecs
branch
4 times, most recently
from
af8e2d3 to
54adba6
Compare
om26er
changed the title
om26er
commented
Oct 31, 2025
| session = connect_anonymous("ws://localhost:8080/ws", "realm1") | ||
| session.set_payload_codec(ProtobufCodec()) | ||
|
|
||
| def event_handler(event: Event): |
Member
Author
There was a problem hiding this comment.
this func needs to handle that directly (of course the unerlying logic needs fixing)
Suggested change
| def event_handler(event: Event): | |
| def event_handler(create: ProfileCreate): |
om26er
commented
Oct 31, 2025
xconn/codec.py
Outdated
| """Serialize a Python object to bytes.""" | ||
| raise NotImplementedError | ||
|
|
||
| def decode(self, data: bytes | str, out_type: Type[T]) -> T: |
Member
Author
There was a problem hiding this comment.
Suggested change
| def decode(self, data: bytes | str, out_type: Type[T]) -> T: | |
| def decode(self, data: Invocation | str, out_type: Type[T]) -> T: |
We actually need a new class that essentially has args, kwargs and details. but is "neutral" to cover Event/Invocation
Mahad-10
force-pushed
the
payload-codecs
branch
from
2cd75f3 to
3e8dbc0
Compare
om26er
force-pushed
the
payload-codecs
branch
from
3e8dbc0 to
9aa1377
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.