Skip to content

git-review-rebase: use fork method when starting multiprocessing manager #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
casasnovas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

git-review-rebase: use fork method when starting multiprocessing manager #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/git-review-rebase/src/git_review_rebase/git_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,12 @@ def patchids(
"""Return a dict[Commit] -> Patchid."""
global _repo, _commit_by_patchid_str
_repo = repo
with multiprocessing.Manager() as manager:
# Use 'fork' explicitly: forkserver (Python 3.14+ default) fails with -1 fds
# when Manager() is called from within asyncio.to_thread().
ctx = multiprocessing.get_context("fork")
Copy link
Copy Markdown

@fallen fallen May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only say that documentation seems to warn a bit on using context "fork" in a multi threaded code

see https://docs.python.org/3/library/multiprocessing.html#multiprocessing-start-methods

with ctx.Manager() as manager:
_commit_by_patchid_str = manager.dict()
with multiprocessing.Pool(multiprocessing.cpu_count()) as p:
with ctx.Pool(multiprocessing.cpu_count()) as p:
p.starmap(
patchid_map_fn,
# Oids objects cannot be pickled so use string representation
Expand Down
Loading