Skip to content

feat: add governance proposal methods to UniFFI bridge#39

Merged
xdustinface merged 1 commit intov0.42-devfrom
claude/issue-38-20260313-2233
Mar 13, 2026
Merged

feat: add governance proposal methods to UniFFI bridge#39
xdustinface merged 1 commit intov0.42-devfrom
claude/issue-38-20260313-2233

Conversation

@xdustinface
Copy link
Owner

Summary

  • Add get_governance_proposals() method returning Vec
  • Add get_governance_proposal(hash) for single proposal lookup
  • Stub implementations (return empty data) since governance engine not yet in SPV client
  • Bridge tests for new methods

Closes #38

Test plan

  • get_governance_proposals returns empty vec (stub)
  • get_governance_proposal returns None for unknown hash

…iFFI bridge

Add stub implementations of get_governance_proposals() -> Vec<GovernanceProposal>
and get_governance_proposal(hash: String) -> Option<GovernanceProposal> to SpvClient
in the UniFFI bridge. Both return empty/None since governance sync is not yet
implemented in the SPV client.

Also adds tokio tests verifying both methods return empty data.

Co-authored-by: Kevin Rombach <xdustinface@users.noreply.github.com>
@xdustinface xdustinface merged commit 8ae458c into v0.42-dev Mar 13, 2026
51 of 52 checks passed
@xdustinface xdustinface deleted the claude/issue-38-20260313-2233 branch March 13, 2026 22:54
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.54%. Comparing base (6adcc57) to head (90d5fdb).
⚠️ Report is 1 commits behind head on v0.42-dev.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev      #39      +/-   ##
=============================================
- Coverage      72.80%   67.54%   -5.27%     
=============================================
  Files            287      316      +29     
  Lines          57461    67696   +10235     
=============================================
+ Hits           41836    45726    +3890     
- Misses         15625    21970    +6345     
Flag Coverage Δ
core 75.14% <ø> (ø)
ffi 37.82% <ø> (?)
rpc 19.92% <ø> (ø)
spv 84.25% <100.00%> (+0.04%) ⬆️
wallet 66.40% <ø> (ø)
Files with missing lines Coverage Δ
dash-spv/src/bridge/mod.rs 89.81% <100.00%> (+0.32%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: wire governance proposal methods in UniFFI bridge

2 participants