feat: add governance proposal methods to UniFFI bridge#39
Merged
xdustinface merged 1 commit intov0.42-devfrom Mar 13, 2026
Merged
feat: add governance proposal methods to UniFFI bridge#39xdustinface merged 1 commit intov0.42-devfrom
xdustinface merged 1 commit intov0.42-devfrom
Conversation
…iFFI bridge Add stub implementations of get_governance_proposals() -> Vec<GovernanceProposal> and get_governance_proposal(hash: String) -> Option<GovernanceProposal> to SpvClient in the UniFFI bridge. Both return empty/None since governance sync is not yet implemented in the SPV client. Also adds tokio tests verifying both methods return empty data. Co-authored-by: Kevin Rombach <xdustinface@users.noreply.github.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.42-dev #39 +/- ##
=============================================
- Coverage 72.80% 67.54% -5.27%
=============================================
Files 287 316 +29
Lines 57461 67696 +10235
=============================================
+ Hits 41836 45726 +3890
- Misses 15625 21970 +6345
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_governance_proposals()method returning Vecget_governance_proposal(hash)for single proposal lookupCloses #38
Test plan