Skip to content

feat: add transaction history methods to UniFFI bridge#41

Merged
xdustinface merged 1 commit intov0.42-devfrom
claude/issue-40-20260313-2301
Mar 13, 2026
Merged

feat: add transaction history methods to UniFFI bridge#41
xdustinface merged 1 commit intov0.42-devfrom
claude/issue-40-20260313-2301

Conversation

@xdustinface
Copy link
Owner

Summary

  • Add get_transactions(limit, offset) method for paginated transaction history
  • Add get_transaction(txid) for single transaction lookup
  • Add get_transaction_count() method
  • Stub implementations returning empty data (wallet integration later)
  • Bridge tests for new methods

Closes #40

Test plan

  • get_transactions returns empty vec (stub)
  • get_transaction returns None for unknown txid
  • get_transaction_count returns 0 (stub)

Add `get_transactions`, `get_transaction`, and `get_transaction_count`
methods to `SpvClient` in the UniFFI bridge. All three return stub/empty
data for now — real transaction history will be wired to wallet data in a
future PR.

Closes #40

Co-authored-by: Kevin Rombach <xdustinface@users.noreply.github.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.57%. Comparing base (8ae458c) to head (a565aa2).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev      #41      +/-   ##
=============================================
- Coverage      72.83%   67.57%   -5.26%     
=============================================
  Files            287      316      +29     
  Lines          57486    67742   +10256     
=============================================
+ Hits           41870    45778    +3908     
- Misses         15616    21964    +6348     
Flag Coverage Δ
core 75.14% <ø> (ø)
ffi 37.82% <ø> (?)
rpc 19.92% <ø> (ø)
spv 84.34% <100.00%> (+0.04%) ⬆️
wallet 66.40% <ø> (ø)
Files with missing lines Coverage Δ
dash-spv/src/bridge/mod.rs 90.36% <100.00%> (+0.55%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xdustinface xdustinface merged commit 1856525 into v0.42-dev Mar 13, 2026
50 of 52 checks passed
@xdustinface xdustinface deleted the claude/issue-40-20260313-2301 branch March 13, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add transaction history methods to UniFFI bridge

2 participants