feat: add send transaction method to UniFFI bridge#44
Merged
xdustinface merged 2 commits intov0.42-devfrom Mar 14, 2026
Merged
Conversation
Add `send_transaction(raw_tx_hex: String) -> Result<SendResult, SpvClientError>` to the `SpvClient` UniFFI wrapper. The method: - Decodes the hex-encoded raw transaction bytes - Deserialises the bytes into a `dashcore::Transaction` - Broadcasts to all connected peers via `DashSpvClient::broadcast_transaction` - Returns a `SendResult` record containing the txid and status on success - Returns `SpvClientError::Transaction` for invalid hex or unparseable bytes - Returns `SpvClientError::Network` when no peers are connected New types: - `SendResult` UniFFI record with `txid` and `status` fields - `SpvClientError::Transaction` variant for transaction-decode errors Tests added for all error paths (invalid hex, invalid bytes, no peers) and record construction/equality. Co-authored-by: Kevin Rombach <xdustinface@users.noreply.github.com>
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.42-dev #44 +/- ##
=============================================
+ Coverage 67.59% 67.65% +0.05%
=============================================
Files 316 316
Lines 67742 67840 +98
=============================================
+ Hits 45793 45898 +105
+ Misses 21949 21942 -7
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send_transaction(raw_tx_hex)method to SpvClientSendResultrecord with txid and statusCloses #42
Test plan