feat: add fee estimation method to UniFFI bridge#53
Merged
xdustinface merged 1 commit intov0.42-devfrom Mar 14, 2026
Merged
Conversation
- Add `FeeEstimate` UniFFI record with `fee: u64` (duffs), `fee_rate: String`, and `estimated_size: u32` fields - Add `SpvClient::estimate_fee(amount, fee_rate)` method: fee rates "low"=1, "medium"=10 (default), "high"=100 duff/byte; size estimated as standard 1-input/2-output P2PKH transaction (226 bytes) - Add 9 unit tests covering all fee rate levels, edge cases (zero amount, unknown rate, case-insensitivity, amount independence) Closes #51 Co-authored-by: Kevin Rombach <xdustinface@users.noreply.github.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.42-dev #53 +/- ##
=============================================
- Coverage 73.01% 67.72% -5.30%
=============================================
Files 287 316 +29
Lines 58149 68474 +10325
=============================================
+ Hits 42456 46371 +3915
- Misses 15693 22103 +6410
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51
Adds fee estimation to the UniFFI bridge:
FeeEstimaterecord withfee(duffs),fee_rate,estimated_size(bytes)estimate_fee(amount, fee_rate)method with static fee rates: low=1, medium=10, high=100 duff/byte