Add POST /SetTTS support and a few fixes#8
Open
ken107 wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed docker entrypoint to install all avaialable MSIs in the language packs directory
I encountered an issue when doing
GET /SetTTS?text=How+are+you%3F&voiceName=. The question mark (%3F) should not affect parsing, but the C# URL parser has bug. I asked Codex to add support for POST that allows sending the text in the body of the request. It also found and fixed the URL parser bug.After that,
POST /SetTTSactually failed with 'text' parameter cannot be empty. Asked Codex to find that fix that as well. Apparently HTTP header case sensitivity was the issue.Codex built the binary as well, you might want to build it yourself to be on the safe side.