Skip to content

💄 Indent the mixin a better way#81

Open
martinsoenen wants to merge 1 commit into
mainfrom
indent-mixin
Open

💄 Indent the mixin a better way#81
martinsoenen wants to merge 1 commit into
mainfrom
indent-mixin

Conversation

@martinsoenen

@martinsoenen martinsoenen commented May 26, 2026

Copy link
Copy Markdown
Contributor

Indent a better way to ensure Pint and other linters are already ok with the file

Summary by CodeRabbit

  • Style
    • Improved formatting of generated PHP stubs for enhanced readability and code consistency.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 808f2a5c-2960-4478-a15d-ac92559b2540

📥 Commits

Reviewing files that changed from the base of the PR and between 772724b and 57673ab.

📒 Files selected for processing (1)
  • src/Manifests/ContainerMixinManifest.php

📝 Walkthrough

Walkthrough

The PR updates the PHP stub string generation in ContainerMixinManifest::write() to use multi-line formatting with separate lines for the opening tag, namespace declaration, and class declaration, replacing the previous compact single-line format.

Changes

Container Mixin Manifest PHP Stub Formatting

Layer / File(s) Summary
Multi-line PHP stub format
src/Manifests/ContainerMixinManifest.php
The generated PHP stub string switches from single-line <?php namespace ...; with tightly packed class Container{} to multi-line format with the opening tag, namespace, and class declaration on separate lines with consistent spacing around the inserted docComment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A stub grows tall with breathing room,
No longer cramped in single gloom,
Each tag and space finds its own line,
The generated code looks so fine!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references improving indentation/formatting of a mixin, which directly aligns with the PR's objective to fix formatting to satisfy Pint linters and the change to reformat the PHP stub in ContainerMixinManifest.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch indent-mixin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant