Merged
Conversation
mikicz
force-pushed
the
chore/update-versions
branch
from
42499c9 to
fe8e5db
Compare
mikicz
force-pushed
the
chore/update-versions
branch
from
fe8e5db to
633dac3
Compare
almeida-raphael
approved these changes
Dec 22, 2025
mikicz
force-pushed
the
chore/update-versions
branch
from
633dac3 to
86ea37a
Compare
robalar
reviewed
Jan 1, 2026
Collaborator
robalar
left a comment
robalar
left a comment
There was a problem hiding this comment.
Looks good, one tiny comment
csv_gp/Cargo.toml
Outdated
Comment on lines
+9
to
+16
| clap = {version = "<5", features = ["derive"] } | ||
| encoding_rs = "<0.9" | ||
| encoding_rs_io = "<0.2" | ||
| csv = "<2" | ||
| thiserror = "<2" | ||
|
|
||
| [dev-dependencies] | ||
| tempfile = "3.3.0" | ||
| tempfile = "<4" |
Collaborator
There was a problem hiding this comment.
Not sure if you had a valid reason to do this but kinda unusual to see the < bound. You are saying that this crate can compile across breaking semver versions, is that true? having a version like encoding_rs = "0.9" or clap = "5", will resolve to the latest non-breaking change (ie 0.9.x or 5.x.x) which is probably what you want?
Collaborator
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
log = "^1.2.3" is exactly equivalent to log = "1.2.3".
This is very confusing! I thought it was like in poetry/uv where it locked it to a specific version
mikicz
force-pushed
the
chore/update-versions
branch
from
d5c6735 to
6c81ae3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/xelixdev/csv-gp/security/dependabot/3 and https://github.com/xelixdev/csv-gp/security/dependabot/4