Fix heartbeat nil value crash in timer and busy indicator#308
Draft
ElleNajt wants to merge 1 commit intoxenodium:mainfrom
Draft
Fix heartbeat nil value crash in timer and busy indicator#308ElleNajt wants to merge 1 commit intoxenodium:mainfrom
ElleNajt wants to merge 1 commit intoxenodium:mainfrom
Conversation
`agent-shell-heartbeat-stop` sets `:value` to nil, but a final timer tick can fire after cancellation and call `(1+ nil)`, causing `(wrong-type-argument number-or-marker-p nil)`. The same nil value propagates to `agent-shell--busy-indicator-frame` via mode-line redisplay, triggering the error there too. Guard both sites with `when-let` to skip when value is nil. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:heartbeat :valuein the timer lambda and busy indicator frame functionProblem
agent-shell-heartbeat-stopsets:valueto nil, butcancel-timerdoesn't prevent an already-dispatched timer tick from running. When that final tick fires, it calls(1+ nil), producing:The same nil value propagates to
agent-shell--busy-indicator-framevia mode-line redisplay during theforce-mode-line-updatecall, triggering the error there too. This results in repeated error spam in*Messages*.Changes
agent-shell-heartbeat.el: Wrap timer lambda body inwhen-letso it skips the tick when value is nilagent-shell.el: Addvaluebinding towhen-let*inagent-shell--busy-indicator-framesomodnever receives nilTest plan
wrong-type-argumenterrors in*Messages*Written by Claude