Skip to content

chore: setup per app cache.#358

Merged
k82cn merged 2 commits intoxflops:mainfrom
k82cn:per_app_cache
Feb 19, 2026
Merged

chore: setup per app cache.#358
k82cn merged 2 commits intoxflops:mainfrom
k82cn:per_app_cache

Conversation

@k82cn
Copy link
Contributor

@k82cn k82cn commented Feb 19, 2026

No description provided.

Signed-off-by: Klaus Ma <klausm@nvidia.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @k82cn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's directory management by separating the concerns of instance-specific working directories and shared per-application cache directories. It introduces a more structured approach to handling uv, pip, and temporary caches, making them reusable across different instances of the same application and providing flexibility through the FLAME_HOME environment variable.

Highlights

  • New Constants: Introduced FLAME_HOME and FLAME_LOG constants in common/src/lib.rs to centralize configuration.
  • Directory Setup Refactoring: The setup_working_directory function in host_shim.rs was refactored to solely create the per-instance working directory.
  • Per-Application Cache: A new setup_cache function was added to host_shim.rs to manage per-application cache directories for uv, pip, and temporary files, allowing these to be shared across instances of the same application. This cache location is configurable via FLAME_HOME.
  • HostShim Initialization: The HostShim::new method was updated to utilize the newly separated setup_working_directory and setup_cache functions for clearer and more modular directory management.
Changelog
  • common/src/lib.rs
    • Added FLAME_HOME and FLAME_LOG constants.
  • executor_manager/src/shims/host_shim.rs
    • Imported FLAME_HOME and FLAME_LOG from common.
    • Removed the local FLAME_LOG constant.
    • Modified setup_working_directory to only create the instance's working directory.
    • Introduced a new setup_cache function to handle per-application cache directories (uv, pip, tmp).
    • Updated HostShim::new to call setup_working_directory and setup_cache separately.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request refactors the setup of working and cache directories for application instances. It introduces a per-application cache for uv and pip, which is a good improvement for sharing dependencies. However, the temporary directory is also made per-application, which could lead to race conditions. My review includes a comment to address this potential issue.

Signed-off-by: Klaus Ma <klausm@nvidia.com>
@k82cn k82cn merged commit 577363e into xflops:main Feb 19, 2026
5 of 6 checks passed
@k82cn k82cn deleted the per_app_cache branch February 19, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant