ir: add metadata read APIs#37
Merged
xushiwei merged 2 commits intoxgo-dev:goplusfrom Apr 14, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces several methods to the Module and Value types to support the retrieval of named metadata and metadata node operands, as well as the identification and extraction of MDStrings. A comprehensive test case has been added to verify these operations. Feedback was provided regarding a redundant CString allocation in the NamedMetadataOperands function, which could be optimized to improve efficiency.
a3a5b78 to
c1a0007
Compare
c1a0007 to
5512c9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing