Add ARM lowering coverage across stdlib asm corpus#10
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
- Coverage 32.44% 31.42% -1.03%
==========================================
Files 41 57 +16
Lines 12646 16380 +3734
==========================================
+ Hits 4103 5147 +1044
- Misses 7809 10365 +2556
- Partials 734 868 +134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive support for translating ARM assembly to LLVM IR. It adds a new CFG-based lowering path for complex functions, implements lowering for a wide range of ARM instructions, and enhances the parser for ARM-specific syntax. The changes are extensive, well-structured, and include thorough testing. I've identified one minor issue in the inline assembly for the MRC instruction.
|
Solid ARM lowering coverage with good test breadth across stdlib corpora. A few items need attention before merge: Correctness (high priority)
Code quality
CI
|
1 participant
Summary
armcorpora, includingMOVM,SWI,MOVD, arithmetic/multiply families, andLDREX/STREXatomicsVerification
go test ./...go test ./...incmd/plan9asmgo test ./...incmd/plan9asmllgo run ./cmd/plan9asmscan -goos linux -goarch arm ...go run ./cmd/plan9asmscan -goos android -goarch arm ...go run ./cmd/plan9asmscan -goos freebsd -goarch arm ...go run ./cmd/plan9asmscan -goos netbsd -goarch arm ...go run ./cmd/plan9asmscan -goos openbsd -goarch arm ...go run ./cmd/plan9asmscan -goos plan9 -goarch arm ...go run ./cmd/plan9asmscan -goos windows -goarch arm ...Notes
android/freebsd/linux/netbsd/openbsd/plan9/windowswithUnsupported Ops = nonewindows/armparser tail was also fixed ($(16 + callbackArgs__size)style immediates)