fix: lazy-load CodeMirror in sourcePeekEditor#437
Merged
claude[bot] merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
xiaolai
force-pushed
the
fix/435-lazy-load-codemirror-source-peek
branch
4 times, most recently
from
50aab34 to
fc83cd4
Compare
…) code split Static imports of @codemirror/* in sourcePeekEditor.ts pulled ~150-200KB of CodeMirror modules into the main WYSIWYG bundle, defeating the React.lazy() code split for SourceEditor. Switch to dynamic import() so CodeMirror is only loaded when a user first activates source peek. Closes #435 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
xiaolai
force-pushed
the
fix/435-lazy-load-codemirror-source-peek
branch
from
fc83cd4 to
f181142
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
importof 6@codemirror/*modules insourcePeekEditor.tsto dynamicimport(), loaded once on first source-peek activationcreateCodeMirrorEditorAPI — returns container immediately, mounts CodeMirror asynchronously inside itCloses #435
Test plan
pnpm check:allpasses (lint, tests, build)🤖 Generated with Claude Code