fix(deploy): refresh frontend dependencies on every release#61
Merged
Conversation
The production runner retained stale node_modules and skipped installing the new shared design-system package. Always run npm ci for both frontends and enforce the behavior with a shell regression contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm cifor both frontends during production releasesnode_modulesshortcut that skipped newly added local packagesRoot Cause
The self-hosted production runner intentionally preserves frontend
node_modules. The deployment script only installed dependencies when that directory was absent, so v2.4.1 did not install the newfile:../code-nest-design-systempackage.Verification
bash -n scripts/ci-server-build-deploy.sh scripts/ci-server-build-deploy.test.sh scripts/deploy-release.shbash scripts/ci-server-build-deploy.test.sh./scripts/code-nest-eval.ps1 -Tier hygieneactions-runneruser