This repository was archived by the owner on Apr 10, 2026. It is now read-only.
fix: sections for docs#100
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the collectSections function to improve performance by eliminating unnecessary array allocations during recursion. Instead of creating new arrays at each recursive level and spreading them into the parent array, the function now accumulates sections in-place by passing the same array reference through all recursive calls.
Key Changes
- Modified function signature to accept an optional
sectionsparameter with a default empty array - Changed recursive call from spreading returned arrays (
sections.push(...collectSections(...))) to passing the accumulator array (collectSections(..., sections))
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
collectSectionsfunction inapps/nextjs-app/lib/sections.tsto improve how sections are accumulated during recursion. Instead of creating a new array on each recursive call, the function now accepts an optionalsectionsparameter and accumulates results in-place, which is more efficient and avoids unnecessary array allocations.Refactoring for efficiency and correctness:
collectSectionsto take an optionalsectionsarray parameter, allowing in-place accumulation of sections during recursion, rather than creating and merging new arrays at each step.collectSectionsto pass the existingsectionsarray, ensuring all discovered sections are collected in the same array.