Conversation
zfreiter
left a comment
zfreiter
left a comment
There was a problem hiding this comment.
Looks really well done.
I couldn't find any big errors in the homework.
Everything worked when I tested.
Overall, great job. The style was well done and the code was also well done.
| } | ||
|
|
||
| else if (req.url === '/check-cookies') { | ||
| let routeResults = getRoutes(); |
There was a problem hiding this comment.
routeResults is never used in the check-cookies route.
Everything in 01 looks great.
Good job.
| let parsedArgs = temp1.split("&"); | ||
|
|
||
| let results = []; | ||
| let temp = []; |
There was a problem hiding this comment.
The temp variable is unused. It could be removed.
| /> | ||
|
|
||
| </head> | ||
| <body class="bg-dark"> |
There was a problem hiding this comment.
The form looks really good.
The style is well done.
| res.write(`<ul> ${routeResults} </ul>`); | ||
| } | ||
|
|
||
| else if (req.url === '/form') { |
There was a problem hiding this comment.
else if should be on the same line as the closing } from the previous if statement.
There a couple instances of this.
ELondonJ
left a comment
ELondonJ
left a comment
There was a problem hiding this comment.
Looks good. I nitpicked a few styling guide requirements.
Good job!
| '/submit' | ||
| ]; | ||
|
|
||
| let body = ""; |
There was a problem hiding this comment.
Clean readable code. On line 48 single quotes should be used for consistency.
| res.write(`<h2>Error 404 - Page not Found</h2>`); | ||
| res.end(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Looks good. For styling, the Airbnb docs require that if else/else statements be on the same line as the previous blocks closing brace
Section 16.1
| res.write(table); | ||
| } | ||
|
|
||
| else if (req.url.indexOf('/characters') >= 0){ |
There was a problem hiding this comment.
Styling - The Airbnb style guide requires a space before the leading brace.
Section 19.2
3 participants
No description provided.