Skip to content

Hw4 submission#4

Open
xiivi wants to merge 2 commits into
mainfrom
hw4
Open

Hw4 submission#4
xiivi wants to merge 2 commits into
mainfrom
hw4

Conversation

@xiivi

@xiivi xiivi commented Nov 13, 2022

Copy link
Copy Markdown
Owner

No description provided.

@JeremyIV

Copy link
Copy Markdown
Collaborator

Ex1: Your 'set cookies' page doesn't actually set a cookie in the browser, please double-check the functionality of your solutions before submitting. Also, why are you including these calls to 'next'? This is leading to some errors in the web service. It's find to just end each response normally within each case here.

Ex2: You're not using express sessions to keep track of the path history; instead, the path history is a single global variable on the server. This means that everyone visiting your website, regardless of whether or not they are in the same express session, will see and contribute to the same list of paths.

Ex3: Looks good, nice job.

Ex4: When I start up this server, I get the error 'fetch is not defined'. I needed to require node fetch to make this work. Maybe this is a consequence of the version of node I'm using? The 'capitals' page displays the capital names only, not the countries, as shown in the homework. Everything else looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants