Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm doing an asrc. I have problem because
multiply_fracwrongly go in overflow.My case is
in rate: 48000
out rate: 48000
num_rate: 500733
den_rate: 500000
num/den = 1.001466
and for example my samp_frac_num is 173475.
then I set
num_rate: 199999
den_rate: 1000000
num/den = 0.199999
this is a big change in ratio, but is done only to test.
When I do this change, I get overflow in multiply_frac function.
remain = 173475 > UINT32_MAX / 1000000 and this go in overflow.
but if I do all the operation with 64bit is ok
remain * num / den + major * num = 173475 * 199999 / 1000000 + 0 * 199999 = 34694 and this is correct.
the 2nd problem is that if multiply_frac fails wile I'm calling
speex_resampler_set_rate_fracthe internal variable is left wrangly updated, and this create more problems later with possible access to invalid memory.