Fix a bunch of EObj columns#236
Merged
Merged
Conversation
These seem to have been grand-fathered in from somewhere, but they're just kinda wrong. "Target" I think is meant to be an indication of whether the EObj is spawned and is targetable, but it's not on the right column. I have no idea what EyeCollision/DirectorControl means nor did Ghidra point to me anything obvious, so I removed those for now. I did figure out a few more fields though, which I have now documented. The only thing I'm somewhat unsure about is the new Targetable column, I only figured that out through process-of-elimination after cross-referencing different SpawnObject packets.
Contributor
✅ Validation succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These seem to have been grand-fathered in from somewhere, but they're just kinda wrong. "Target" I think is meant to be an indication of whether the EObj is spawned and is targetable, but it's not on the right column. I have no idea what EyeCollision/DirectorControl means nor did Ghidra point to me anything obvious, so I removed those for now.
I did figure out a few more fields though, which I have now documented. The only thing I'm somewhat unsure about is the new Targetable column, I only figured that out through process-of-elimination after cross-referencing different SpawnObject packets.