Skip to content

Fix API break & expand elsewhere#17

Closed
oconnor0 wants to merge 5 commits intomasterfrom
expand-api
Closed

Fix API break & expand elsewhere#17
oconnor0 wants to merge 5 commits intomasterfrom
expand-api

Conversation

@oconnor0
Copy link
Copy Markdown
Collaborator

@oconnor0 oconnor0 commented Feb 23, 2026

This does 4 different things. Any of which can be rejected without affecting the others (except that 3 depends on 2):

  1. Change Xledger.Collections.Test tests via public API & reflection rather than having internal access. This changes how resolution of internal vs public is handled to more closely match third-party users of the library.
  2. Support ReadOnlySpan on .NET 48. - which is why the .NET 48 version of this package depends on System.Memory.
  3. Support collection expressions on .NET 48. - by implementing the single attribute polyfill that the compiler needs to specify the correct builder method.
  4. Test new ImmArray construction. - since there is a breaking change in the API between 0.8.0 and 0.9.0 in C# 12 (tho not in C# 14).
  5. Remove new ImmArray(params ReadOnlySpan) to revert API break.

@oconnor0 oconnor0 requested a review from isaksky February 23, 2026 19:10
@oconnor0 oconnor0 changed the title Expand API Fix API break & expand elsewhere Feb 23, 2026
@oconnor0 oconnor0 closed this Feb 23, 2026
@oconnor0 oconnor0 deleted the expand-api branch February 23, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant