Conversation
There was a problem hiding this comment.
Pull request overview
Updates the VitePress-based XMapTools documentation site for “version 1.2”, including new getting-started/installation content, refreshed navigation, and migration of many embedded images to the external Documentation_Images repository.
Changes:
- Add new “Getting started” pages and a detailed macOS/Windows installation & update guide.
- Restructure site navigation (nav + sidebar) and refresh the home page links/images.
- Update project metadata (version bump, script change, license change) and expand contributor documentation in
README.md.
Reviewed changes
Copilot reviewed 16 out of 52 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| videos.md | Adds a new “Videos” landing page stub. |
| tutorials.md | Switches many images/icons to Documentation_Images raw URLs; some doc text/formatting issues introduced. |
| package.json | Bumps version to 1.2.0, changes dev script, updates author/license. |
| installation_guide.md | New detailed installation/update guide for macOS and Windows. |
| index.md | Updates homepage CTA links and replaces some images with external <img> tags. |
| getting-started.md | New intro + compatibility matrix; links into installation guide. |
| getting-started-2.md | New “first launch” guide and common questions. |
| documentation.md | Removes the old placeholder documentation page. |
| doc-laicpms.md | Adds initial LA-ICP-MS documentation page/content. |
| doc-epma.md | Adds extensive EPMA documentation page/content. |
| README.md | Replaces minimal README with full contributor/setup guidance. |
| .vitepress/config.js | Updates logo location and significantly expands nav/sidebar structure. |
| .vitepress/cache/deps/* | Adds VitePress cache artifacts (should not be committed). |
| .gitignore | Adds duplicate .DS_Store entries; still doesn’t ignore root .vitepress/cache. |
| .github/workflows/vitepress.yml | Removes the step that copied assets/* into .vitepress/public. |
| .DS_Store | Adds an OS-generated file (should not be committed). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot open a new pull request to apply changes based on the comments in this thread |
* Initial plan * Fix typo: change 'figure bellow' to 'figure below' in tutorials.md Co-authored-by: lanari <54409312+lanari@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lanari <54409312+lanari@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 52 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
getting-started-2.md
Outdated
|
|
||
| ## I am lost, where can I get some help? | ||
|
|
||
| You can find articles on this website and help files in the program. We also have [tutorial videos](/tutorials.html). Do not hesitate to click on the help button available in each section to access a description of the main steps. If you feel that something is missing or unclear, or if you find an error, do not hesitate to contact us on [Discord](https://discord.com/invite/2ak9RXcJ5b) or via the [developer repository](https://github.com/xmaptools/XMapTools_Developers) on GitHub. |
There was a problem hiding this comment.
This page links to /tutorials.html, which is unlikely to exist in the VitePress build. Use the /tutorials route instead.
doc-epma.md
Outdated
| @@ -0,0 +1,450 @@ | |||
| # XMapTools documentation for EPMA | |||
|
|
|||
| ## Table of content | |||
There was a problem hiding this comment.
Section title should be plural: “Table of content” → “Table of contents”.
package.json
Outdated
| "author": "XMapTools", | ||
| "license": "GNU General Public License v3.0" |
There was a problem hiding this comment.
The package metadata now declares the project under GPLv3, but there is no LICENSE file in the repo. To avoid ambiguity for downstream users, add a LICENSE file containing the GPLv3 text (or the chosen license) and ensure it matches the README/package.json.
| import { | ||
| BaseTransition, | ||
| BaseTransitionPropsValidators, | ||
| Comment, | ||
| DeprecationTypes, |
There was a problem hiding this comment.
The .vitepress/cache/deps output is generated by Vite/VitePress dependency optimization and shouldn’t be committed. Remove this file (and the rest of .vitepress/cache/) from the repo and add .vitepress/cache/ to .gitignore to avoid huge diffs and merge conflicts.
| text: Installation | ||
| link: /installation_guide |
There was a problem hiding this comment.
The home page hero image is still set to /assets/Logo_2025_square_512.Xsq7Ybeo.png, but this repo no longer contains an assets/ directory and the Pages workflow no longer copies assets into the build output. Update hero.image.src to a valid URL (e.g., the Documentation_Images raw URL) or reintroduce an assets publishing step.
doc-epma.md
Outdated
| - JEOL (SUN) requires two files for each map: 'XX.cnd' and 'XX_map.txt', and two files for each set of spot analyses: 'summary.txt' and 'stage.txt'. | ||
| - CAMECA requires one file for each map: 'XXXX.txt', and a single file for each set of spot analyses: 'YYY.csv'. | ||
|
|
||
| #### Step 2: Set the destimation folder |
There was a problem hiding this comment.
Typo in heading: “destimation” → “destination”.
doc-laicpms.md
Outdated
| @@ -0,0 +1,103 @@ | |||
| # XMapTools documentation | |||
|
|
|||
| ## Table of content | |||
There was a problem hiding this comment.
Section title should be plural: “Table of content” → “Table of contents”.
| mkdir -p .vitepress/public | ||
| cp -R assets/* .vitepress/public/ | ||
|
|
||
| # Setup GitHub Pages |
There was a problem hiding this comment.
Since the workflow no longer copies a local assets/ directory into the published site, any remaining /assets/... references will break on Pages. There is at least one in index.md (hero.image.src); either update the docs to use the external Documentation_Images URLs everywhere or restore an assets publish step.
getting-started-2.md
Outdated
| - Working with **EPMA** data? Try this [tutorial](/tutorials.html#tutorial-1-xmaptools-for-epma-2023). | ||
| - Working with **LA-ICP-MS** data? Read this [paper](https://pierrelanari.com/wp-content/uploads/2024/01/2024_Markmann_ChemGeol.pdf). |
There was a problem hiding this comment.
/tutorials.html#... looks like a legacy/static-site URL and is likely to 404 under VitePress’ default routing. Update this link to point to the VitePress route for the tutorials page (and the correct heading anchor).
|
@copilot open a new pull request to apply changes based on the comments in this thread |
* Initial plan * Changes before error encountered Co-authored-by: lanari <54409312+lanari@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: lanari <54409312+lanari@users.noreply.github.com>
version 1.2