Open
Conversation
virginiab10
approved these changes
Mar 3, 2026
Comment on lines
+198
to
+200
| "clientId": accessToken.channelID, | ||
| "expiresIn": accessToken.expiresIn, | ||
| "scope": accessToken.permissions.map { $0.rawValue }.joined(separator: " ") | ||
| "scope": accessToken.permissions.map { $0.rawValue }.joined(separator: " ") |
There was a problem hiding this comment.
Are these changes ok?
I read that "clientId | string | The channel ID the access token was issued for." and "channelId | string | Your LINE Login channel ID. |"
but I'm a bit confused, I assume is correct because clientId definition mentions accessToken but as is a sensitive change a double check won't be bad.
Also I see a strange space there but it's a really minor thing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔄 Type of change:
✏️ Description: