test(d14n): bump xmtpd test images to the #2020 build (XIP-83 QueryApi.Subscribe bidi)#3787
Conversation
…i.Subscribe bidi)
The d14n test stack pinned ghcr.io/xmtp/xmtpd{,-gateway,-cli} to v1.3.0 (Mar 2026),
which predates xmtpd #2020 (XIP-83 d14n QueryApi.Subscribe, merged 2026-06-26) — so the
containers had no bidi-streaming RPC. Pin to sha-ac17e82, the #2020 merge build, so d14n
client integration can run against a node that serves Subscribe. Frozen SHA (not :main)
keeps the shared CI dep reproducible; no tagged release carries the RPC yet.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Claude finished @tylerhawkes's task —— View job PR Review - 2026-06-26 20:01 UTCTasks
Review✅ Approved — The changes are clean, well-documented, and follow best practices for Docker compose pinning. Highlights
No issues found
Optional future improvementConsider adding the full 40-character commit SHA to the comment (lines 1-3) for extra clarity: # Pinned to the xmtpd #2020 merge commit (ac17e820b8d997e92c8006f69fc94049ffd3bdad)This matches the verification mentioned in the PR description and provides an unambiguous reference, though the short SHA |
ApprovabilityVerdict: Approved Test infrastructure change bumping Docker image versions in a dev-only docker-compose file. The author owns this file, and the change has no production runtime impact. You can customize Macroscope's approvability policy. Learn more. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3787 +/- ##
=======================================
Coverage 84.40% 84.40%
=======================================
Files 409 409
Lines 60138 60138
=======================================
Hits 50759 50759
Misses 9379 9379 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What
Bump the d14n test stack images (
dev/docker/docker-compose-d14n.yml) fromv1.3.0to the #2020 build:ghcr.io/xmtp/xmtpdv1.3.0sha-ac17e82ghcr.io/xmtp/xmtpd-gatewayv1.3.0sha-ac17e82ghcr.io/xmtp/xmtpd-cliv1.3.0sha-ac17e82Why
v1.3.0was cut Mar 2026 — months before xmtpd #2020 (XIP-83 d14nQueryApi.Subscribebidi streaming, merged 2026-06-26). So the d14n test containers had no bidi-streaming RPC, which blocks the upcoming d14n client integration tests. Pinning to the #2020 build gives them the capability.Why a SHA, not
:main: there is no tagged release with the RPC yet (latest isv1.3.0).sha-ac17e82is the #2020 merge commit, so it's a frozen, reproducible pin — it won't drift when unrelated xmtpdmainchanges land, matching this compose's existing fixed-pin philosophy. Swap to a release tag once one ships with the RPC.Verification
ac17e820b8d997e92c8006f69fc94049ffd3bdad— exactly the mock db #2020 merge commit, so the binary containsQueryApi.Subscribeby construction.docker compose -f dev/docker/docker-compose-d14n.yml configvalidates; all three images pull.Note on v3
The v3 stack (
docker-compose.yml) usesghcr.io/xmtp/node-go:main, which has carried the bidi RPC since node-go #562 — no change needed there (a stale local cache just needs a re-pull).🤖 Generated with Claude Code
Note
Bump xmtpd test images to build sha-ac17e82 for XIP-83 QueryApi.Subscribe bidi
Updates docker-compose-d14n.yml to pin
xmtpd,xmtpd-gateway, andxmtpd-cliimages fromv1.3.0tosha-ac17e82, a specific merge commit that includes the XIP-83QueryApi.Subscribebidirectional streaming support needed for d14n tests.Macroscope summarized 7fe1ecb.