Fix node logging bugs, add missing ReplicaSet watch, remove committed binary#20
Merged
xonas1101 merged 4 commits intofeat-add-node-loggingfrom Mar 18, 2026
Merged
Conversation
Merged
…ch, add node test, update sample CR Co-authored-by: xonas1101 <81941842+xonas1101@users.noreply.github.com>
Co-authored-by: xonas1101 <81941842+xonas1101@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [#15] Add logging for nodes
Fix node logging bugs, add missing ReplicaSet watch, remove committed binary
Mar 12, 2026
xonas1101
requested changes
Mar 12, 2026
…e support Co-authored-by: xonas1101 <81941842+xonas1101@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review and fixes for the node logging feature added in the previous commit.
go1.23.4.linux-amd64.tar.gz(71MB) from repo, add*.tar.gzto.gitignorenodeLine()— nodes are cluster-scoped;node.Namespaceis always empty, producing a spurious space in outputReplicaSetwatch inSetupWithManager— deployments, pods, and nodes all had watches but replicasets did not, so RS changes never triggered reconciliationtestNodehelper + test case verifying observed count for node resourcesconfig/samples/logger_v1_logger.yaml— replace scaffold TODO with a working sample CR including all resource typesexample/crd.yaml— addnodesto the resources listREADME.md— reflect Node support throughout (description, feature list, usage instructions, and YAML example)✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.