I/O exceptions refactoring#364
Merged
Merged
Conversation
Member
Author
|
Backported to XP11 and released in https://github.com/xp-framework/core/releases/tag/v11.11.0 |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #363, resolving the name collision with PHP's
Io\IoExceptionclass introduced as part of https://wiki.php.net/rfc/poll_api#exception_hierarchy in php/php-src#19572Implementation status
xp-framework/coreEffects on userland code
When using PHP < 8.6, nothing will change for existing code: Raising and catching
io.IOExceptionwill use the class alias:For PHP 8.6, the native class will be thrown (and caught). For direct uses, this will continue to work, but using it for its base class character will break code as follows:
The path forward
This means libraries should start migrating to the new class hierarchy based in
io.OperationFailednow. This will create quite a bit of library releases; quite a few of which will also need to drop support for older XP core releases.