Skip to content

fix: add compatible return type to Contacts::getIterator() #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rogatec wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

fix: add compatible return type to Contacts::getIterator() #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/contacts/Contacts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace de\xqueue\maileon\api\client\contacts;

use ArrayIterator;
use Traversable;
use de\xqueue\maileon\api\client\xml\AbstractXMLWrapper;
use IteratorAggregate;
use SimpleXMLElement;
Expand Down Expand Up @@ -39,9 +40,9 @@ public function addContact($contact)
}

/**
* @return ArrayIterator an iterator for the contacts in this list of contacts
* @return Traversable an iterator for the contacts in this list of contacts
*/
public function getIterator()
public function getIterator(): Traversable
{
return new ArrayIterator($this->contacts);
}
Expand Down