fix(verifier): use reachable solc list mirror and persist compilers#2
Open
vriveraPeersyst wants to merge 1 commit into
Open
fix(verifier): use reachable solc list mirror and persist compilers#2vriveraPeersyst wants to merge 1 commit into
vriveraPeersyst wants to merge 1 commit into
Conversation
The smart-contract-verifier could not verify contracts because it failed to fetch the Solidity compiler list from binaries.soliditylang.org from inside the container. Point the Solidity LIST_URL to the ethereum/solc-bin gh-pages mirror (identical content, served over GitHub) and keep the original URL as a commented fallback. Add bind-mount volumes for the solc/vyper compiler caches so downloaded compilers survive container restarts, matching the repo's existing bind-mount convention (stats-db-data, etc.). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The smart-contract-verifier could not verify contracts (error:
Couldn't fetch the file … https://solc-…). From inside the container it failed to fetch the Solidity compiler list fromhttps://binaries.soliditylang.org/linux-amd64/list.json. Without that catalog the service cannot resolve/download the requested compiler (e.g. 0.8.30), so verification fails.What
LIST_URLto the canonical GitHub mirror —https://raw.githubusercontent.com/ethereum/solc-bin/gh-pages/linux-amd64/list.json. Same contentbinaries.soliditylang.orgis served from, confirmed current (contains0.8.30). Original soliditylang URL kept as a commented fallback with a WHY note. The blockscout/solc-bin mirror was rejected — stale (max 0.8.14)./tmp/solidity-compilersand/tmp/vyper-compilers(matching the existingstats-db-data/redis-dataconvention) so downloaded compilers survive container restarts.Files:
docker-compose/envs/common-smart-contract-verifier.env,docker-compose/services/smart-contract-verifier.yml,.gitignore.How to confirm the root cause (from the Docker host)
How to test
docker exec smart-contract-verifier sh -c 'wget -S -O /dev/null https://raw.githubusercontent.com/ethereum/solc-bin/gh-pages/linux-amd64/list.json'→ expect200 OK.Notes
dockerunavailable in the dev environment; changes validated by inspection. Runtime test-verify is the deployment step above.🤖 Generated with Claude Code