feat(web): add smooth scrolling and enhance installation component#2
Open
Odunsih1 wants to merge 1 commit into
Open
feat(web): add smooth scrolling and enhance installation component#2Odunsih1 wants to merge 1 commit into
Odunsih1 wants to merge 1 commit into
Conversation
- Add smooth scrolling behavior to html element - Remove redundant peer flags from package-lock.json dependencies - Update Installation component to support multiple copy buttons with individual feedback - Improve UI consistency for package manager installation commands
|
@Odunsih1 is attempting to deploy a commit to the Akinkunmi Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="web/src/components/Installation.tsx">
<violation number="1" location="web/src/components/Installation.tsx:9">
P2: Earlier copy timeouts can clear `copiedId` after a newer copy, making the “Copied!” feedback disappear too soon when clicking multiple buttons quickly.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| const handleCopy = (text: string, id: string) => { | ||
| navigator.clipboard.writeText(text); | ||
| setCopiedId(id); | ||
| setTimeout(() => setCopiedId(null), 2000); |
There was a problem hiding this comment.
P2: Earlier copy timeouts can clear copiedId after a newer copy, making the “Copied!” feedback disappear too soon when clicking multiple buttons quickly.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At web/src/components/Installation.tsx, line 9:
<comment>Earlier copy timeouts can clear `copiedId` after a newer copy, making the “Copied!” feedback disappear too soon when clicking multiple buttons quickly.</comment>
<file context>
@@ -1,12 +1,12 @@
+ const handleCopy = (text: string, id: string) => {
+ navigator.clipboard.writeText(text);
+ setCopiedId(id);
+ setTimeout(() => setCopiedId(null), 2000);
};
</file context>
Suggested change
| setTimeout(() => setCopiedId(null), 2000); | |
| setTimeout(() => setCopiedId(prev => (prev === id ? null : prev)), 2000); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds smooth scrolling site-wide and upgrades the Installation component with per-command copy buttons and clear feedback. Improves UI consistency for npm, pnpm, and yarn instructions.
New Features
Dependencies
Written for commit 745ce6d. Summary will update on new commits.