Add runtime batch_bool mask overloads for complex batch load/store - #1391
Open
DiamonDinoia wants to merge 1 commit into
Open
Add runtime batch_bool mask overloads for complex batch load/store#1391DiamonDinoia wants to merge 1 commit into
DiamonDinoia wants to merge 1 commit into
Conversation
The scalar batch<T, A> already accepted both batch_bool_constant (compile-time) and batch_bool (runtime) masks for load/store, but batch<std::complex<T>, A> was missing the runtime overloads. This made it impossible to use a dynamic mask with complex batches. Changes: - Declare and define load(value_type const*, batch_bool<T,A>, Mode) and store(value_type*, batch_bool<T,A>, Mode) for batch<std::complex<T>>. - Implement both with a scalar fallback: load zeroes inactive lanes, store only writes active lanes. - Add runtime-mask load/store tests in test_batch_complex.cpp. The existing free-function API in xsimd_api.hpp already documented that batch_bool overloads exist and are slower than batch_bool_constant; no documentation or comment churn in the headers was needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scalar batch<T, A> already accepted both batch_bool_constant (compile-time) and batch_bool (runtime) masks for load/store, but batch<std::complex, A> was missing the runtime overloads. This made it impossible to use a dynamic mask with complex batches.
Simple naive implementation for now just API parity.