Fix xview assignment through leading newaxis slices#2896
Open
Alex-PLACET wants to merge 1 commit intoxtensor-stack:masterfrom
Open
Fix xview assignment through leading newaxis slices#2896Alex-PLACET wants to merge 1 commit intoxtensor-stack:masterfrom
Alex-PLACET wants to merge 1 commit intoxtensor-stack:masterfrom
Conversation
…ple leading `newaxis()` slices
Contributor
Author
|
Addressing #2228 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This PR fixes incorrect index mapping in xview assignments when a view starts with one or more newaxis() slices.
The change updates the index computation to use a newaxis-aware slice index before applying integral-slice adjustments. That keeps writes through views with multiple leading newaxis() entries aligned with the correct element in the underlying tensor.