Skip to content

Fix CSV reader to handle 8-bit integers#2904

Merged
JohanMabille merged 1 commit intoxtensor-stack:masterfrom
Alex-PLACET:fix_csv_reader_with_8bit_int
Apr 30, 2026
Merged

Fix CSV reader to handle 8-bit integers#2904
JohanMabille merged 1 commit intoxtensor-stack:masterfrom
Alex-PLACET:fix_csv_reader_with_8bit_int

Conversation

@Alex-PLACET
Copy link
Copy Markdown
Contributor

@Alex-PLACET Alex-PLACET commented Apr 30, 2026

Checklist

  • The title and commit message(s) are descriptive.
  • Small commits made to fix your PR have been squashed to avoid history pollution.
  • Tests have been added for new features or bug fixes.
  • API of new functions and classes are documented.

Description

Address #2453

This PR fixes xcsv parsing for 8-bit integer types and adds focused test coverage around CSV load and dump behavior.

  • fix lexical_cast for signed char and unsigned char so CSV values like 0 and 1 are parsed numerically instead of through character extraction
  • fix string cell trimming so leading and trailing spaces are removed correctly

@Alex-PLACET Alex-PLACET marked this pull request as ready for review April 30, 2026 09:19
@Alex-PLACET Alex-PLACET changed the title Fix CSV reader to handle 8-bit integers and add comprehensive tests Fix CSV reader to handle 8-bit integers Apr 30, 2026
@JohanMabille
Copy link
Copy Markdown
Member

Thanks!

@JohanMabille JohanMabille merged commit 68f9a77 into xtensor-stack:master Apr 30, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants