addon-image: Kitty graphics q=2 should suppress OK responses too#5884
Open
sotasan wants to merge 1 commit into
Open
addon-image: Kitty graphics q=2 should suppress OK responses too#5884sotasan wants to merge 1 commit into
sotasan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the Kitty graphics protocol spec:
The current
_sendResponseimplementation inKittyGraphicsHandler.tsonly matchesquiet === 1for OK andquiet === 2for errors, so a transmission withq=2still emits anOKresponse — a violation of the spec and a real-world breakage for crossterm-based clients (e.g. yazi) that sendq=2precisely to get silence and whose input parser misinterprets the unsolicited APC response as keystrokes. Concretely, hovering over an image in yazi pumpsESC _ G i = N ; O K ESC \into stdin, which crossterm reads as;(open shell command line),G(jump to bottom),O(open with).Changes
quiet === 1→quiet >= 1for OK andquiet === 2→quiet >= 2for errors, making q=2 suppress both. Adds 4 tests mirroring the existing q=1 OK-suppression coverage:a=q): "suppresses OK response when q=2"a=t): "a=t OK suppressed by q=2"a=T): "a=T OK suppressed by q=2"a=p): "OK response suppressed by q=2"The 2-character behavior change has been validated end-to-end in a downstream xterm.js consumer where yazi previews now work cleanly.