fix: remove aria-hidden from DOM renderer row container#5885
Open
jpavonabian wants to merge 1 commit into
Open
fix: remove aria-hidden from DOM renderer row container#5885jpavonabian wants to merge 1 commit into
jpavonabian wants to merge 1 commit into
Conversation
The row container was unconditionally hidden from screen readers via aria-hidden=\"true\", making all terminal output inaccessible. Since the DOM renderer renders actual text in the DOM, removing this attribute is sufficient to restore screen reader access. The screenReaderMode option and AccessibilityManager remain unchanged and continue to provide an enhanced experience (live region, structured tree) when explicitly enabled. Fixes Issue xtermjs#5881
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-hidden="true"from_rowContainer(.xterm-rows) inDomRenderer.ts_selectionContainerkeeps itsaria-hidden="true"(correct — it is a visual-only overlay)screenReaderModeoption andAccessibilityManagerare unchanged and continue to provide an enhanced experience (live region, structured accessible tree) when explicitly enabledMotivation
aria-hidden="true"was unconditionally set on the row container, making all terminal output completely invisible to screen readers whenscreenReaderModeisfalse(the default). SinceAccessibilityManageronly activates whenscreenReaderMode: true, the default configuration left screen reader users with zero access to terminal output.Accessibility should not depend on the embedding developer knowing to opt in via
screenReaderMode.Closes #5881