Improve decoration cell lookup performance#5886
Open
tt-a1i wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #5176.
This speeds up decoration lookup for the common single-line decoration case. When no registered decoration spans multiple rows,
forEachDecorationAtCellnow asks the sorted decoration list for the current line instead of scanning every decoration for every cell.Multi-line decorations continue to use the existing full scan path so their behavior is unchanged.
Validation
npm run build && npm run esbuildnpm run test-unit -- out-esbuild/common/services/DecorationService.test.js out-esbuild/common/SortedList.test.jsnpm run lint-changesNotes
A local micro-benchmark with 10k single-line decorations over an 80x24 viewport for 20 iterations went from about 2479ms on the full-scan path to about 6.9ms with the line-keyed fast path.