Revamp/v4.0.0 -> Master#114
Open
xx-shitai-xx wants to merge 65 commits intomasterfrom
Open
Conversation
Refactor the GServer - Part 1
Fixed wrong names in includes. Fixed some missing includes causing build errors.
Renamed the class `CScriptEngine` to `ScriptEngine` across all files and functions.
Fixed the name of SCachedLevel. Removed an empty comment.
Refactor the GServer - Part 2
The function to minify NPC script works off of normal \n line breaks. There were cases where the script was using \xa7 linebreaks, which would cause the minify function to break and erase the whole script. This removes the conversion of \n to \xa7 in the `Server::addNpc` code since the minify function performs that duty. This also fixes the `join` command, which was converting to \xa7 before being passed through minify. Finally, this updates `Player::msgPLI_PUTNPC` to properly mark the NPC type as `PUTNPC` instead of `LEVELNPC`.
Fix putnpc and join for GS1.
Added a new IdGenerator template class to handle id assignment. Moved player, external player, npc, and baddy id handling to the new class.
Added test for IdGenerator. IdGenerator restricted to std::integral types. Enabled tests for Windows.
Standardized id management.
Visual Studio identified cases where numerical overflow could occur before widening and where unintentional copies could be made on usage of "auto". This commit fixes those issues by widening to size_t beforehand, properly using auto&, and explicitly making value copies when necessary.
Code cleanup.
Added BabyDI and migrated Server into it. Replaced pointers of server being passed around with calls to BabyDI.
X/Y/Z are stored in pixel coordinates and converted. Added missing NPC Z properties.
For some reason the build server was exploding on the usage of size_t when it had never complained before. To fix it, make sure we include cstddef.
Another round of code cleanup
Bugfix/codecleanup
Feature/npc server file perms
Fix musl build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.