Scripting sendtext and requesttext + onReceiveText#118
Open
xx-shitai-xx wants to merge 3 commits intodevfrom
Open
Scripting sendtext and requesttext + onReceiveText#118xx-shitai-xx wants to merge 3 commits intodevfrom
xx-shitai-xx wants to merge 3 commits intodevfrom
Conversation
xtjoeytx
reviewed
Jan 16, 2025
Comment on lines
+915
to
+922
| for (const auto& [npcName, npcPtr]: m_server->getNPCNameList()) | ||
| { | ||
| // TODO(joey): check if they have the event before queueing for them | ||
| if (const auto npcObject = npcPtr.lock(); npcObject && npcName == params[0]) | ||
| { | ||
| npcObject->queueNpcEvent("npc.receivetext", true, data.toString()); | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Hm, this is a map on the npc name itself - why the traversal, and why do I need to check if they have the event before queueing for them?!
Collaborator
Author
There was a problem hiding this comment.
I'll clean this up :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.