Changes I needed to get this to build on apple with gcc-15.#120
Open
Changes I needed to get this to build on apple with gcc-15.#120
Conversation
Also needed to run cmake like so: -DUPNP=OFF -DCMAKE_OSX_SYSROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.2.sdk
xtjoeytx
commented
Feb 7, 2026
Comment on lines
+94
to
+95
| elseif(UNIX) | ||
| target_compile_definitions(${target} PUBLIC PLATFORM_UNIX) |
Owner
Author
There was a problem hiding this comment.
Apple defines both UNIX & APPLE, so fixed ordering
xtjoeytx
commented
Feb 7, 2026
|
|
||
| #ifdef __APPLE__ | ||
| #include <mach-o/dyld.h> | ||
| #endif |
Owner
Author
There was a problem hiding this comment.
required for _NSGetExecutablePath
xtjoeytx
commented
Feb 7, 2026
Comment on lines
+379
to
+381
| # set_property( | ||
| # TARGET ${TARGET_NAME} APPEND_STRING PROPERTY COMPILE_FLAGS "-fobjc-arc" | ||
| # ) |
Owner
Author
There was a problem hiding this comment.
Not needed for Apple + GCC builds, needed for clang build
xtjoeytx
commented
Feb 7, 2026
Comment on lines
+119
to
+121
| if(HOMEBREW_PREFIX) | ||
| set(ZLIB_ROOT "${HOMEBREW_PREFIX}/opt/zlib" CACHE PATH "" FORCE) | ||
| set(BZIP2_ROOT "${HOMEBREW_PREFIX}/opt/bzip2" CACHE PATH "" FORCE) |
xtjoeytx
commented
Feb 7, 2026
Comment on lines
+98
to
+99
| add_compile_options($<$<COMPILE_LANGUAGE:CXX>:-stdlib=libstdc++>) | ||
| add_link_options($<$<LINK_LANGUAGE:CXX>:-stdlib=libstdc++>) |
Owner
Author
There was a problem hiding this comment.
these were necessary, may not be necessary if gs2lib gets updated
LoneBoco
force-pushed
the
beta4
branch
2 times, most recently
from
5ba9dbf to
ec79b78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also needed to run cmake like so:
-DUPNP=OFF -DCMAKE_OSX_SYSROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.2.sdk