Removing dependencies, simplify CMakeLists, and fix Rust build#16
Open
cernec1999 wants to merge 21 commits intomainfrom
Open
Removing dependencies, simplify CMakeLists, and fix Rust build#16cernec1999 wants to merge 21 commits intomainfrom
cernec1999 wants to merge 21 commits intomainfrom
Conversation
…ectory, bump version numbers, update deps
…user to have flex and bison installed as part of a build requirement
…ectory, bump version numbers, update deps
Collaborator
Author
|
Actually, I was misinformed about Install instructions: |
xx-shitai-xx
requested changes
Dec 18, 2024
Collaborator
xx-shitai-xx
left a comment
There was a problem hiding this comment.
Left some comments for you to take a look at and resolve before it can be merged
xx-shitai-xx
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR makes several improvements and adjustments to streamline the build process, reduce dependencies, and resolve compatibility issues. Below are the details:
1. Replaced
fmtlibDependency with Customprintf_format_stringfmtlibto a customprintf_format_stringimplementation that uses traditional C-style format specifiers.std::formatwould be the ideal solution, it is not yet supported by many compilers. This custom implementation simplifies the dependency chain while maintaining functionality.2. Removed
winflexbisonDependencywinflexbison,find_packageis now used to locateflexandbison. Users are expected to install these packages as they already do on macOS or Linux.--wincompatflag forflexto ensure compatibility with Windows, allowing the build to succeed without relying onunistd.h.3. Removed
emscriptenand Associated JS Interface Filesemscriptenhas been removed.js_interfacefile used for JavaScript interactions has been deleted, as it is no longer relevant.4. Refactored Output Directory Settings in
CMakeLists.txtCMAKE_ARCHIVE_OUTPUT_DIRECTORY,CMAKE_LIBRARY_OUTPUT_DIRECTORY, etc.) from theCMakeLists.txtfile.cmakecommand.lib/directory conflicted with Rust's expected build structure, causingcargo publishto fail. Rust enforces that files remain in the specified build directories unless manually overridden.5. Removed GitHub Action for NPM Releases
6. Resolved Node Architecture Issue in CI/CD
node("amd64")in Jenkins to ensure builds are executed on anamd64runner.