Fixes alignment of DICOM data due to failure to round#147
Open
adrew0809 wants to merge 1 commit intoxtk:masterfrom
Open
Fixes alignment of DICOM data due to failure to round#147adrew0809 wants to merge 1 commit intoxtk:masterfrom
adrew0809 wants to merge 1 commit intoxtk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should offset into data by integer multiple of the slice size, but
_distance_positioncan be a non-integerdue to arithmetic precision in the calculation when ordering by
image_position_patient. This led to misaligned volume slices. The simple fix ensures we multiply the slice size by an integer.