log messages updated for getAllTestCases & getAllTestSuites functions#76
Open
CameliaFarcas wants to merge 1 commit intodevelopfrom
Open
log messages updated for getAllTestCases & getAllTestSuites functions#76CameliaFarcas wants to merge 1 commit intodevelopfrom
CameliaFarcas wants to merge 1 commit intodevelopfrom
Conversation
CameliaFarcas
requested review from
AlexeiSuleac,
ConorSmyth,
flynnmichaelj and
jenny-flynn
| file, err := os.Open(fmt.Sprintf("%s%s", testCasePathDir, filename)) | ||
| if err != nil { | ||
| logrus.Error("Cannot Open File: " + filename) | ||
| logrus.Error("File not found: " + filename) |
Collaborator
There was a problem hiding this comment.
Would it not be better to say something like:
logrus.Error("Error opening the file: ", err )
I would also add the error as in example.
ConorSmyth
approved these changes
Mar 12, 2018
jenny-flynn
reviewed
Mar 16, 2018
| byteValue, err := ioutil.ReadAll(file) | ||
| if err != nil { | ||
| logrus.Error("Cannot Read File: " + filename) | ||
| logrus.Error("An error has occured : " + filename) |
Collaborator
There was a problem hiding this comment.
log the error. this will help with debugging the issue.
jenny-flynn
reviewed
Mar 16, 2018
| err = xml.Unmarshal(byteValue, testCase) | ||
| if err != nil { | ||
| logrus.Error("Cannot Unmarshall File: " + filename) | ||
| logrus.Error("Bad request: " + filename) |
Collaborator
There was a problem hiding this comment.
log the error. this will help with debugging the issue.
jenny-flynn
reviewed
Mar 16, 2018
| file, err := os.Open(fmt.Sprintf("%s%s", testSuitePathDir, filename)) | ||
| if err != nil { | ||
| logrus.Error("Cannot open file: ", filename) | ||
| logrus.Error("File not found: ", filename) |
Collaborator
There was a problem hiding this comment.
log the error. this will help with debugging the issue.
jenny-flynn
reviewed
Mar 16, 2018
| byteValue, err := ioutil.ReadAll(file) | ||
| if err != nil { | ||
| logrus.Error("Cannot Read File: ", filename) | ||
| logrus.Error("An error has occured: ", filename) |
Collaborator
There was a problem hiding this comment.
log the error. this will help with debugging the issue.
jenny-flynn
reviewed
Mar 16, 2018
| err = xml.Unmarshal(byteValue, testSuite) | ||
| if err != nil { | ||
| logrus.Error("Cannot Unmarshall: ", filename) | ||
| logrus.Error("Bad request: ", filename) |
Collaborator
There was a problem hiding this comment.
log the error. this will help with debugging the issue.
Collaborator
|
resolve conflicts in this PR before making changes to other PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jenny-flynn please review the details added to the log