Develop#77
Conversation
…ted-perf-test into feature/XAPTC-18
…ted-perf-test into feature/XAPTC-18
-Updating Buttons and file selector
…ted-perf-test into feature/XAPTC-18 # Conflicts: # uiServices/src/testSuiteServices.go
…ted-perf-test into feature/XAPTC-18
-added godog test for get all
| @@ -4,4 +4,6 @@ main | |||
| .idea | |||
There was a problem hiding this comment.
can you also add
config/*.xml
!config/config.xml
*.iml
.idea
ui/
automated-perf-test
uiServices/test/*.xml
reuse functions add logging
…ted-perf-test into develop # Conflicts: # config/TestCaseService2.xml # config/config2222.xml # config/configkkk.xml # uiServices/src/configServices.go # uiServices/src/homepage.go # uiServices/src/testCaseServices.go # uiServices/src/testCaseServices_test.go # uiServices/test/GodogTestCase.xml # uiServices/test/GodogTestCase2.xml # uiServices/test/testCase.feature
|
@CameliaFarcas @jenny-flynn & @AlexeiSuleac when you get a chance can you take a look a take a look at this PR. I am nearly certain that there could be improvements made, If there is technical debt lets create cards for it unless it really quick aka less than 1.5hour. I have everything passing now. I have merged both XAPTC-18 and XAPTC-10.1 and XAPTC-63 in this branch. These branches are still waiting approval in the PR state to merged into master. The plan for this branch is to merge this into master and then keep develop branch around as the main development branch and all future branches will be created from this one. When we cut a release or tag we will merge it into master. |
| "dependencies": { | ||
| "@angular/animations": "^5.1.3", | ||
| "@angular/cdk": "^5.0.3", | ||
| "@angular-devkit/core": "^5.0.0", |
There was a problem hiding this comment.
Does this work now with "^5.0.0"?
| }, | ||
| "devDependencies": { | ||
| "@angular/cli": "1.6.8", | ||
| "@angular/cli": "1.6.3", |
There was a problem hiding this comment.
Why going down a version? Just curious
There was a problem hiding this comment.
@AlexeiSuleac as this was the origanal version we started with. It doesn't really make a difference any way it is only the patch version and should be backward compatible.
| @@ -1,47 +1,19 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
can you restore this config file?
| ResponseContentType string `xml:"responseContentType"` | ||
| Headers []Header `xml:"headers>header"` | ||
| ResponseValues []ResponseValue `xml:"responseProperties>value"` | ||
| PreThinkTime int64 `xml:"preThinkTime"` |
There was a problem hiding this comment.
I don't think we need to expose these to be unmarshalled into the XML config/defs files
|
|
||
| func postConfigs(rw http.ResponseWriter, req *http.Request) { | ||
| configPathDir := req.Header.Get("configPathDir") | ||
| rw.Header().Set("Access-Control-Allow-Origin", "*") |
There was a problem hiding this comment.
i think we could have a return method at the end of each handler that adds this header, the body, and the status code to the request.
| request.Header.Set("configPathDir", filePath) | ||
| request.Header.Get("configPathDir") | ||
| request.Header.Set("path", filePath) | ||
| request.Header.Get("path") |
There was a problem hiding this comment.
this line can be removed in each place it occurs
restore original config.xml
| XMLName xml.Name `xml:"testCase" json:"testCase"` | ||
| XMLName xml.Name `xml:"testCase"` | ||
| Name string `xml:",chardata"` | ||
| Description string `xml:"description,attr" json:"description"` |
There was a problem hiding this comment.
I think i remember hearing we didn't want to make this change
7 participants
I think there is a few issues with unit tests and integrations tests on the Go side I am still having a look at it.
I have merged in XAPTC 10.1 and XAPTC 18