Feature/xaptc 51#78
Open
CameliaFarcas wants to merge 117 commits intomasterfrom
Open
Conversation
…ted-perf-test into feature/XAPTC-18
…ted-perf-test into feature/XAPTC-18
-Updating Buttons and file selector
…ted-perf-test into feature/XAPTC-18 # Conflicts: # uiServices/src/testSuiteServices.go
…ted-perf-test into feature/XAPTC-18
-added godog test for get all
reuse functions add logging
…ted-perf-test into develop # Conflicts: # config/TestCaseService2.xml # config/config2222.xml # config/configkkk.xml # uiServices/src/configServices.go # uiServices/src/homepage.go # uiServices/src/testCaseServices.go # uiServices/src/testCaseServices_test.go # uiServices/test/GodogTestCase.xml # uiServices/test/GodogTestCase2.xml # uiServices/test/testCase.feature
restore original config.xml
CameliaFarcas
requested review from
AlexeiSuleac,
ConorSmyth,
flynnmichaelj and
jenny-flynn
jenny-flynn
requested changes
Apr 3, 2018
| ui/ | ||
| **/node_modules | ||
| /.editorconfig No newline at end of file | ||
| /.editorconfig |
Collaborator
There was a problem hiding this comment.
duplicate of lines 1-7?
| ResponseContentType string `xml:"responseContentType"` | ||
| Headers []Header `xml:"headers>header"` | ||
| ResponseValues []ResponseValue `xml:"responseProperties>value"` | ||
| PreThinkTime int64 `xml:"preThinkTime"` |
Collaborator
There was a problem hiding this comment.
Don't include this change (prethinktime, postthinktime, execweight).
@ConorSmyth Should this be merging to develop?
| expect(configPO.rampDelay.getAttribute("value")).toEqual("15"); | ||
| expect(configPO.rampUsers.getAttribute("value")).toEqual("5"); | ||
| }); | ||
| // it("should check values of existing file are as expected", () => { |
| } | ||
| case 400: { | ||
| this.toastr.error( | ||
| "No Test Suite Directory added", |
Collaborator
There was a problem hiding this comment.
an error occurred because the request in incorrect. Should we point the user towards looking at the request that was made?
| "baseStatsOutputDir": { "type": "string" }, | ||
| "reportOutputDir": { "type": "string" } | ||
| "enum": [ | ||
| "Default-1", |
Collaborator
There was a problem hiding this comment.
@ConorSmyth do we have a card to get away from populating this field from the schema?
| return | ||
| } | ||
| } | ||
| rw.WriteHeader(http.StatusOK) |
Collaborator
There was a problem hiding this comment.
return rw.WriteHeader(http.StatusNoContent)
| request.Header.Set("testSuitePathDir", filePath) | ||
| request.Header.Get("testSuitePathDir") | ||
| request.Header.Set("path", filePath) | ||
| request.Header.Get("path") |
| request.Header.Set("testSuitePathDir", filePath) | ||
| request.Header.Get("testSuitePathDir") | ||
| request.Header.Set("path", filePath) | ||
| request.Header.Get("path") |
| request.Header.Set("testSuitePathDir", DirectoryPath) | ||
| request.Header.Get("testSuitePathDir") | ||
| request.Header.Set("path", DirectoryPath) | ||
| request.Header.Get("path") |
| request.Header.Get("path") | ||
|
|
||
| w := httptest.NewRecorder() | ||
| r.ServeHTTP(w, request) |
jenny-flynn
reviewed
Apr 3, 2018
| "responseStatusCode": { | ||
| "type": "number" | ||
| "type": "integer", | ||
| "minimum": 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review e2e tests for Test Cases