Open
Conversation
Author
|
I think this is actually ready for review, it has been working for me on two versions of Neovim (0.11.5 and the current master). If you are interested that is. |
xyb3rt
force-pushed
the
main
branch
2 times, most recently
from
5c97abb to
213b00a
Compare
xyb3rt
force-pushed
the
main
branch
7 times, most recently
from
4164c42 to
c91d5fd
Compare
We now use the WinClosed autocmd for this which means that it also happens when using builtin vim functionality to close the window.
…ffering Add Neovim-compatible wrappers for job control (s:JobStop, s:ChanSend, s:ChanCloseIn, s:ChanSetCallback, s:JobInfo, s:GetJobBufNr), emulate Vim's 'out_io':'buffer' behavior via s:NvimOut/s:NvimExit callbacks, handle signal sending via vim.loop.kill, initialize script-local click variables, fix readdir() call (two parameters, not three), and fix various Vimscript and callback regressions introduced during porting.
Add AcmeActivate public function and key mappings. Add fallback in
s:RightRelease to use getmousepos() when s:click is uninitialized.
Fix mouse handling for Neovim 0.12+ where normal! with mouse key events
is restricted. Use getline('.') in s:RightRelease for correct
column-based plumbing pattern matching.
Author
|
Rebased on the top of the current Please, review, and let me know if you would consider this PR, or I should go away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far it seems to work more or less fine with my Neovim 0.11.5, but I have already found one bug (see the last commit in this PR), and I would probably rather give it a bit more time (a week or so). If you are not interested in having the plugin useful for both Vim and Neovim users, just let me know, and I will gladly maintain my own Neovim only (and mostly likely Lua-only) fork.