Skip to content

feat: Upgrade velox submodule to y-scope/velox@6fabc5.#146

Merged
kirkrodrigues merged 1 commit intorelease-0.293-clp-connectorfrom
2026-02-19-update-velox
Feb 19, 2026
Merged

feat: Upgrade velox submodule to y-scope/velox@6fabc5.#146
kirkrodrigues merged 1 commit intorelease-0.293-clp-connectorfrom
2026-02-19-update-velox

Conversation

@20001020ycx
Copy link

@20001020ycx 20001020ycx commented Feb 19, 2026

Description

This PR is to update the Velox submodule to sync the merged PRs y-scope/velox#48 to have the support of custom S3 object storage.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Summary by CodeRabbit

  • Chores
    • Updated internal dependency version with no functional or behavioural changes to the application.

@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The pull request updates the Velox submodule pointer in the presto-native-execution directory from commit 52bb2fedafd6b7ceb12bb60ef959d2a290e82f17 to commit 6fabc5e70d039ef3b5f7591f9f787480a9c3136e with no functional or behavioral modifications.

Changes

Cohort / File(s) Summary
Submodule pointer
presto-native-execution/velox
Updated Velox submodule reference to a newer commit (52bb2fe → 6fabc5e).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • kirkrodrigues
  • wraymo
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description provides the motivation (custom S3 object storage support) and references the related PR, but does not follow the repository's required template structure with sections like Motivation and Context, Impact, and Test Plan. Restructure the description to follow the template with sections for Description, Motivation and Context, Impact, Test Plan, and complete the Release Notes section with either specific notes or 'NO RELEASE NOTE'.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: upgrading the velox submodule to a specific commit hash with conventional commits format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 2026-02-19-update-velox

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kirkrodrigues kirkrodrigues merged commit 3543aa9 into release-0.293-clp-connector Feb 19, 2026
92 of 94 checks passed
@20001020ycx 20001020ycx deleted the 2026-02-19-update-velox branch February 19, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants